Skip to content

Commit 6c7a0a6

Browse files
committed
nfs/localio: avoid pointless cred reference count bumps
filp->f_cred already holds a reference count that is stable during the operation. Link: https://lore.kernel.org/r/20241125-work-cred-v2-13-68b9d38bb5b2@kernel.org Acked-by: Chuck Lever <chuck.lever@oracle.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> Reviewed-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent bd05aeb commit 6c7a0a6

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

fs/nfs/localio.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@ static void nfs_local_call_read(struct work_struct *work)
374374
struct iov_iter iter;
375375
ssize_t status;
376376

377-
save_cred = override_creds(get_new_cred(filp->f_cred));
377+
save_cred = override_creds(filp->f_cred);
378378

379379
nfs_local_iter_init(&iter, iocb, READ);
380380

@@ -384,7 +384,7 @@ static void nfs_local_call_read(struct work_struct *work)
384384
nfs_local_read_done(iocb, status);
385385
nfs_local_pgio_release(iocb);
386386

387-
put_cred(revert_creds(save_cred));
387+
revert_creds(save_cred);
388388
}
389389

390390
static int
@@ -545,7 +545,7 @@ static void nfs_local_call_write(struct work_struct *work)
545545
ssize_t status;
546546

547547
current->flags |= PF_LOCAL_THROTTLE | PF_MEMALLOC_NOIO;
548-
save_cred = override_creds(get_new_cred(filp->f_cred));
548+
save_cred = override_creds(filp->f_cred);
549549

550550
nfs_local_iter_init(&iter, iocb, WRITE);
551551

@@ -558,7 +558,7 @@ static void nfs_local_call_write(struct work_struct *work)
558558
nfs_local_vfs_getattr(iocb);
559559
nfs_local_pgio_release(iocb);
560560

561-
put_cred(revert_creds(save_cred));
561+
revert_creds(save_cred);
562562
current->flags = old_flags;
563563
}
564564

0 commit comments

Comments
 (0)