Skip to content

Commit 6e7628c

Browse files
kwilczynskiLorenzo Pieralisi
authored andcommitted
PCI: microchip: Remove dev_err() when handing an error from platform_get_irq()
There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. This change is as per suggestions from Coccinelle, e.g., drivers/pci/controller/pcie-microchip-host.c:1027:2-9: line 1027 is redundant because platform_get_irq() already prints an error Related commit caecb05 ("PCI: Remove dev_err() when handing an error from platform_get_irq()"). Link: https://lore.kernel.org/r/20210310131913.2802385-1-kw@linux.com Signed-off-by: Krzysztof Wilczyński <kw@linux.com> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
1 parent 2c61f32 commit 6e7628c

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

drivers/pci/controller/pcie-microchip-host.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1023,10 +1023,8 @@ static int mc_platform_init(struct pci_config_window *cfg)
10231023
}
10241024

10251025
irq = platform_get_irq(pdev, 0);
1026-
if (irq < 0) {
1027-
dev_err(dev, "unable to request IRQ%d\n", irq);
1026+
if (irq < 0)
10281027
return -ENODEV;
1029-
}
10301028

10311029
for (i = 0; i < NUM_EVENTS; i++) {
10321030
event_irq = irq_create_mapping(port->event_domain, i);

0 commit comments

Comments
 (0)