Skip to content

Commit 6eaf087

Browse files
paulmenzelrafaeljw
authored andcommitted
ACPICA: executer/exsystem: Warn about sleeps greater than 10 ms
ACPICA commit 2a0d1d475e7ea1c815bee1e0692d81db9a7c909c Quick boottime is important, so warn about sleeps greater than 10 ms. Distribution Linux kernels reach initrd in 350 ms, so excessive delays should be called out. 10 ms is chosen randomly, but three of such delays would already make up ten percent of the boottime. Link: acpica/acpica@2a0d1d47 Signed-off-by: Bob Moore <robert.moore@intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Reported-by: kernel test robot <lkp@intel.com>
1 parent ace8f1c commit 6eaf087

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

drivers/acpi/acpica/exsystem.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,16 @@ acpi_status acpi_ex_system_do_sleep(u64 how_long_ms)
169169

170170
acpi_ex_exit_interpreter();
171171

172+
/*
173+
* Warn users about excessive sleep times, so ASL code can be improved to
174+
* use polling or similar techniques.
175+
*/
176+
if (how_long_ms > 10) {
177+
ACPI_WARNING((AE_INFO,
178+
"Firmware issue: Excessive sleep time (%llu ms > 10 ms) in ACPI Control Method",
179+
how_long_us));
180+
}
181+
172182
/*
173183
* For compatibility with other ACPI implementations and to prevent
174184
* accidental deep sleeps, limit the sleep time to something reasonable.

0 commit comments

Comments
 (0)