Skip to content

Commit 7015bb5

Browse files
ZheyuMahdeller
authored andcommitted
video: fbdev: s3fb: Error out if 'pixclock' equals zero
The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of 'pixclock', it may cause divide error. Fix this by checking whether 'pixclock' is zero in s3fb_check_var(). The following log reveals it: divide error: 0000 [#1] PREEMPT SMP KASAN PTI RIP: 0010:s3fb_check_var+0x3f3/0x530 Call Trace: <TASK> fb_set_var+0x367/0xeb0 do_fb_ioctl+0x234/0x670 fb_ioctl+0xdd/0x130 do_syscall_64+0x3b/0x90 Signed-off-by: Zheyu Ma <zheyuma97@gmail.com> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent e1e9651 commit 7015bb5

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

drivers/video/fbdev/s3fb.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -549,6 +549,9 @@ static int s3fb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
549549
int rv, mem, step;
550550
u16 m, n, r;
551551

552+
if (!var->pixclock)
553+
return -EINVAL;
554+
552555
/* Find appropriate format */
553556
rv = svga_match_format (s3fb_formats, var, NULL);
554557

0 commit comments

Comments
 (0)