Skip to content

Commit 707928b

Browse files
ribaldamchehab
authored andcommitted
media: go7007: Use min and max macros
Replace ternary inline selection of f1 and f2 min max values with min() and max() helper functions for the sake of readability and to make coccinelle happier drivers/media/usb/go7007/go7007-fw.c:1292:14-15: WARNING opportunity for max() drivers/media/usb/go7007/go7007-fw.c:1293:14-15: WARNING opportunity for min() Link: https://lore.kernel.org/linux-media/20240429-fix-cocci-v3-5-3c4865f5a4b0@chromium.org Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
1 parent 9a6f132 commit 707928b

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/media/usb/go7007/go7007-fw.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1289,8 +1289,8 @@ static int avsync_to_package(struct go7007 *go, __le16 *code, int space)
12891289
0xbf99, (u16)((-adjratio) >> 16),
12901290
0xbf92, 0,
12911291
0xbf93, 0,
1292-
0xbff4, f1 > f2 ? f1 : f2,
1293-
0xbff5, f1 < f2 ? f1 : f2,
1292+
0xbff4, max(f1, f2),
1293+
0xbff5, min(f1, f2),
12941294
0xbff6, f1 < f2 ? ratio : ratio + 1,
12951295
0xbff7, f1 > f2 ? ratio : ratio + 1,
12961296
0xbff8, 0,

0 commit comments

Comments
 (0)