Skip to content

Commit 9a6f132

Browse files
ribaldamchehab
authored andcommitted
media: uvcvideo: Use max() macro
It makes the code slightly more clear and makes cocci incredibly happy: drivers/media/usb/uvc/uvc_ctrl.c:839:22-23: WARNING opportunity for max() Link: https://lore.kernel.org/linux-media/20240429-fix-cocci-v3-4-3c4865f5a4b0@chromium.org Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
1 parent c039459 commit 9a6f132

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/media/usb/uvc/uvc_ctrl.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -836,7 +836,7 @@ static s32 uvc_get_le_value(struct uvc_control_mapping *mapping,
836836
while (1) {
837837
u8 byte = *data & mask;
838838
value |= offset > 0 ? (byte >> offset) : (byte << (-offset));
839-
bits -= 8 - (offset > 0 ? offset : 0);
839+
bits -= 8 - max(offset, 0);
840840
if (bits <= 0)
841841
break;
842842

0 commit comments

Comments
 (0)