Skip to content

Commit 72a3a50

Browse files
Uwe Kleine-Königandersson
authored andcommitted
hwspinlock: omap: Emit only one error message for errors in .remove()
If a remove callback of a platform driver returns a non-zero value, the driver core emits an error message, otherwise ignores the value and completes unbinding the device. As omap_hwspinlock_remove() already emits an error message, suppress the core's error message by returning zero. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Baolin Wang <baolin.wang@linux.alibaba.com> Link: https://lore.kernel.org/r/20230314180100.2865801-1-u.kleine-koenig@pengutronix.de Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent 3c81195 commit 72a3a50

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/hwspinlock/omap_hwspinlock.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ static int omap_hwspinlock_remove(struct platform_device *pdev)
153153
ret = hwspin_lock_unregister(bank);
154154
if (ret) {
155155
dev_err(&pdev->dev, "%s failed: %d\n", __func__, ret);
156-
return ret;
156+
return 0;
157157
}
158158

159159
pm_runtime_disable(&pdev->dev);

0 commit comments

Comments
 (0)