Skip to content

Commit 76e8173

Browse files
akagoe01dliviu
authored andcommitted
drm/panthor: Correct the order of arguments passed to gem_sync
This commit corrects the order of arguments passed to panthor_gem_sync() function, called when the SYNC_WAIT condition has to be evaluated for a blocked GPU queue. Fixes: cd2c9c3 ("drm/panthor: Add flag to map GEM object Write-Back Cacheable") Signed-off-by: Akash Goel <akash.goel@arm.com> Reviewed-by: Steven Price <steven.price@arm.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> Link: https://patch.msgid.link/20260305110723.2871733-1-akash.goel@arm.com Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
1 parent ee8ade4 commit 76e8173

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

drivers/gpu/drm/panthor/panthor_sched.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -893,14 +893,15 @@ panthor_queue_get_syncwait_obj(struct panthor_group *group, struct panthor_queue
893893

894894
out_sync:
895895
/* Make sure the CPU caches are invalidated before the seqno is read.
896-
* drm_gem_shmem_sync() is a NOP if map_wc=true, so no need to check
896+
* panthor_gem_sync() is a NOP if map_wc=true, so no need to check
897897
* it here.
898898
*/
899-
panthor_gem_sync(&bo->base.base, queue->syncwait.offset,
899+
panthor_gem_sync(&bo->base.base,
900+
DRM_PANTHOR_BO_SYNC_CPU_CACHE_FLUSH_AND_INVALIDATE,
901+
queue->syncwait.offset,
900902
queue->syncwait.sync64 ?
901903
sizeof(struct panthor_syncobj_64b) :
902-
sizeof(struct panthor_syncobj_32b),
903-
DRM_PANTHOR_BO_SYNC_CPU_CACHE_FLUSH_AND_INVALIDATE);
904+
sizeof(struct panthor_syncobj_32b));
904905

905906
return queue->syncwait.kmap + queue->syncwait.offset;
906907

0 commit comments

Comments
 (0)