Skip to content

Commit 79a4c23

Browse files
frankcrawfordgroeck
authored andcommitted
hwmon: (it87) Remove tests nolonger required
Remove DMI tests for boards that are known to have issues with entering configuration mode, as now we are testing the chips directly and no longer need to rely on matching the board. Leave the DMI table in place, for the nVIDIA board, and any future expansions. Signed-off-by: Frank Crawford <frank@crawford.emu.id.au> Link: https://lore.kernel.org/r/20240428060653.2425296-5-frank@crawford.emu.id.au Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent e58095c commit 79a4c23

1 file changed

Lines changed: 0 additions & 48 deletions

File tree

drivers/hwmon/it87.c

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -3683,27 +3683,6 @@ static int it87_dmi_cb(const struct dmi_system_id *dmi_entry)
36833683
return 1;
36843684
}
36853685

3686-
/*
3687-
* On various Gigabyte AM4 boards (AB350, AX370), the second Super-IO chip
3688-
* (IT8792E) needs to be in configuration mode before accessing the first
3689-
* due to a bug in IT8792E which otherwise results in LPC bus access errors.
3690-
* This needs to be done before accessing the first Super-IO chip since
3691-
* the second chip may have been accessed prior to loading this driver.
3692-
*
3693-
* The problem is also reported to affect IT8795E, which is used on X299 boards
3694-
* and has the same chip ID as IT8792E (0x8733). It also appears to affect
3695-
* systems with IT8790E, which is used on some Z97X-Gaming boards as well as
3696-
* Z87X-OC.
3697-
* DMI entries for those systems will be added as they become available and
3698-
* as the problem is confirmed to affect those boards.
3699-
*/
3700-
static int it87_sio_force(const struct dmi_system_id *dmi_entry)
3701-
{
3702-
__superio_enter(REG_4E);
3703-
3704-
return it87_dmi_cb(dmi_entry);
3705-
};
3706-
37073686
/*
37083687
* On the Shuttle SN68PT, FAN_CTL2 is apparently not
37093688
* connected to a fan, but to something else. One user
@@ -3726,34 +3705,7 @@ static struct it87_dmi_data nvidia_fn68pt = {
37263705
.driver_data = data, \
37273706
}
37283707

3729-
#define IT87_DMI_MATCH_GBT(name, cb, data) \
3730-
IT87_DMI_MATCH_VND("Gigabyte Technology Co., Ltd.", name, cb, data)
3731-
37323708
static const struct dmi_system_id it87_dmi_table[] __initconst = {
3733-
IT87_DMI_MATCH_GBT("AB350", it87_sio_force, NULL),
3734-
/* ? + IT8792E/IT8795E */
3735-
IT87_DMI_MATCH_GBT("AX370", it87_sio_force, NULL),
3736-
/* ? + IT8792E/IT8795E */
3737-
IT87_DMI_MATCH_GBT("Z97X-Gaming G1", it87_sio_force, NULL),
3738-
/* ? + IT8790E */
3739-
IT87_DMI_MATCH_GBT("TRX40 AORUS XTREME", it87_sio_force, NULL),
3740-
/* IT8688E + IT8792E/IT8795E */
3741-
IT87_DMI_MATCH_GBT("Z390 AORUS ULTRA-CF", it87_sio_force, NULL),
3742-
/* IT8688E + IT8792E/IT8795E */
3743-
IT87_DMI_MATCH_GBT("B550 AORUS PRO AC", it87_sio_force, NULL),
3744-
/* IT8688E + IT8792E/IT8795E */
3745-
IT87_DMI_MATCH_GBT("X570 AORUS MASTER", it87_sio_force, NULL),
3746-
/* IT8688E + IT8792E/IT8795E */
3747-
IT87_DMI_MATCH_GBT("X570 AORUS PRO", it87_sio_force, NULL),
3748-
/* IT8688E + IT8792E/IT8795E */
3749-
IT87_DMI_MATCH_GBT("X570 AORUS PRO WIFI", it87_sio_force, NULL),
3750-
/* IT8688E + IT8792E/IT8795E */
3751-
IT87_DMI_MATCH_GBT("X570S AERO G", it87_sio_force, NULL),
3752-
/* IT8689E + IT87952E */
3753-
IT87_DMI_MATCH_GBT("Z690 AORUS PRO DDR4", it87_sio_force, NULL),
3754-
/* IT8689E + IT87952E */
3755-
IT87_DMI_MATCH_GBT("Z690 AORUS PRO", it87_sio_force, NULL),
3756-
/* IT8689E + IT87952E */
37573709
IT87_DMI_MATCH_VND("nVIDIA", "FN68PT", it87_dmi_cb, &nvidia_fn68pt),
37583710
{ }
37593711

0 commit comments

Comments
 (0)