Skip to content

Commit 7ce9dd5

Browse files
rddunlaplumag
authored andcommitted
drm/msm/dpu: dpu_hw_lm.h: fix all kernel-doc warnings
Correct or add kernel-doc comments to eliminate all warnings: Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h:27 Cannot find identifier on line: * Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h:52 Incorrect use of kernel-doc format: * Clear layer mixer to pipe configuration Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h:59 Incorrect use of kernel-doc format: * Configure layer mixer to pipe configuration Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h:69 Incorrect use of kernel-doc format: * setup_border_color : enable/disable border color Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h:76 Incorrect use of kernel-doc format: * setup_misr: Enable/disable MISR Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h:81 Incorrect use of kernel-doc format: * collect_misr: Read MISR signature Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h:84 struct member 'setup_mixer_out' not described in 'dpu_hw_lm_ops' Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h:84 struct member 'setup_blend_config' not described in 'dpu_hw_lm_ops' Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h:84 struct member 'setup_alpha_out' not described in 'dpu_hw_lm_ops' Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h:84 struct member 'clear_all_blendstages' not described in 'dpu_hw_lm_ops' Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h:84 struct member 'setup_blendstage' not described in 'dpu_hw_lm_ops' Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h:84 struct member 'setup_border_color' not described in 'dpu_hw_lm_ops' Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h:84 struct member 'setup_misr' not described in 'dpu_hw_lm_ops' Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h:84 struct member 'collect_misr' not described in 'dpu_hw_lm_ops' Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Patchwork: https://patchwork.freedesktop.org/patch/695648/ Link: https://lore.kernel.org/r/20251219184638.1813181-10-rdunlap@infradead.org Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
1 parent f6d7545 commit 7ce9dd5

1 file changed

Lines changed: 11 additions & 12 deletions

File tree

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,39 +25,38 @@ struct dpu_hw_color3_cfg {
2525
};
2626

2727
/**
28-
*
2928
* struct dpu_hw_lm_ops : Interface to the mixer Hw driver functions
3029
* Assumption is these functions will be called after clocks are enabled
3130
*/
3231
struct dpu_hw_lm_ops {
33-
/*
34-
* Sets up mixer output width and height
32+
/**
33+
* @setup_mixer_out: Sets up mixer output width and height
3534
* and border color if enabled
3635
*/
3736
void (*setup_mixer_out)(struct dpu_hw_mixer *ctx,
3837
struct dpu_hw_mixer_cfg *cfg);
3938

40-
/*
41-
* Alpha blending configuration
39+
/**
40+
* @setup_blend_config: Alpha blending configuration
4241
* for the specified stage
4342
*/
4443
void (*setup_blend_config)(struct dpu_hw_mixer *ctx, uint32_t stage,
4544
uint32_t fg_alpha, uint32_t bg_alpha, uint32_t blend_op);
4645

47-
/*
48-
* Alpha color component selection from either fg or bg
46+
/**
47+
* @setup_alpha_out: Alpha color component selection from either fg or bg
4948
*/
5049
void (*setup_alpha_out)(struct dpu_hw_mixer *ctx, uint32_t mixer_op);
5150

5251
/**
53-
* Clear layer mixer to pipe configuration
52+
* @clear_all_blendstages: Clear layer mixer to pipe configuration
5453
* @ctx : mixer ctx pointer
5554
* Returns: 0 on success or -error
5655
*/
5756
int (*clear_all_blendstages)(struct dpu_hw_mixer *ctx);
5857

5958
/**
60-
* Configure layer mixer to pipe configuration
59+
* @setup_blendstage: Configure layer mixer to pipe configuration
6160
* @ctx : mixer ctx pointer
6261
* @lm : layer mixer enumeration
6362
* @stage_cfg : blend stage configuration
@@ -67,19 +66,19 @@ struct dpu_hw_lm_ops {
6766
struct dpu_hw_stage_cfg *stage_cfg);
6867

6968
/**
70-
* setup_border_color : enable/disable border color
69+
* @setup_border_color : enable/disable border color
7170
*/
7271
void (*setup_border_color)(struct dpu_hw_mixer *ctx,
7372
struct dpu_mdss_color *color,
7473
u8 border_en);
7574

7675
/**
77-
* setup_misr: Enable/disable MISR
76+
* @setup_misr: Enable/disable MISR
7877
*/
7978
void (*setup_misr)(struct dpu_hw_mixer *ctx);
8079

8180
/**
82-
* collect_misr: Read MISR signature
81+
* @collect_misr: Read MISR signature
8382
*/
8483
int (*collect_misr)(struct dpu_hw_mixer *ctx, u32 *misr_value);
8584
};

0 commit comments

Comments
 (0)