Skip to content

Commit 8360257

Browse files
azeemshaikh38kees
authored andcommitted
drm/sun4i: hdmi: Replace all non-returning strlcpy with strscpy
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] KSPP#89 Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20230522155331.2336966-1-azeemshaikh38@gmail.com
1 parent 3213bfd commit 8360257

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ int sun4i_hdmi_i2c_create(struct device *dev, struct sun4i_hdmi *hdmi)
304304
adap->owner = THIS_MODULE;
305305
adap->class = I2C_CLASS_DDC;
306306
adap->algo = &sun4i_hdmi_i2c_algorithm;
307-
strlcpy(adap->name, "sun4i_hdmi_i2c adapter", sizeof(adap->name));
307+
strscpy(adap->name, "sun4i_hdmi_i2c adapter", sizeof(adap->name));
308308
i2c_set_adapdata(adap, hdmi);
309309

310310
ret = i2c_add_adapter(adap);

0 commit comments

Comments
 (0)