Skip to content

Commit 83ba6ef

Browse files
committed
spi: rockchip: Use plain request_irq()
The Rockchip driver has since interrupt support was added used request_threaded_irq() but not actually supplied a threaded handler, handling everything in the primary handler. This is equivalent to just using a plain request_irq(), and since aef30c8 (genirq: Warn about using IRQF_ONESHOT without a threaded handler) the current behaviour has triggered a WARN_ON(). Convert to use request_irq(). Reported-by: Aishwarya TCV <Aishwarya.TCV@arm.com> Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com> Signed-off-by: Mark Brown <broonie@kernel.org> Link: https://patch.msgid.link/20260116-spi-rockchip-threaded-irq-v1-1-c45c3a5a38b1@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 0f93ddd commit 83ba6ef

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/spi/spi-rockchip.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -805,8 +805,8 @@ static int rockchip_spi_probe(struct platform_device *pdev)
805805
if (ret < 0)
806806
goto err_put_ctlr;
807807

808-
ret = devm_request_threaded_irq(&pdev->dev, ret, rockchip_spi_isr, NULL,
809-
IRQF_ONESHOT, dev_name(&pdev->dev), ctlr);
808+
ret = devm_request_irq(&pdev->dev, ret, rockchip_spi_isr, 0,
809+
dev_name(&pdev->dev), ctlr);
810810
if (ret)
811811
goto err_put_ctlr;
812812

0 commit comments

Comments
 (0)