Skip to content

Commit 8744eee

Browse files
jwrdegoedeJiri Kosina
authored andcommitted
HID: lenovo: Set LEDs max_brightness value
The LEDs can only by turned on/off, so max_brightness should be set to 1. Without this the max_brightness sysfs-attribute will report 255 which is wrong. Reviewed-by: Marek Behún <kabel@kernel.org> Acked-by: Pavel Machek <pavel@ucw.cz> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
1 parent 033c978 commit 8744eee

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/hid/hid-lenovo.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -822,6 +822,7 @@ static int lenovo_register_leds(struct hid_device *hdev)
822822

823823
data->led_mute.name = name_mute;
824824
data->led_mute.brightness_set_blocking = lenovo_led_brightness_set;
825+
data->led_mute.max_brightness = 1;
825826
data->led_mute.flags = LED_HW_PLUGGABLE;
826827
data->led_mute.dev = &hdev->dev;
827828
ret = led_classdev_register(&hdev->dev, &data->led_mute);
@@ -830,6 +831,7 @@ static int lenovo_register_leds(struct hid_device *hdev)
830831

831832
data->led_micmute.name = name_micm;
832833
data->led_micmute.brightness_set_blocking = lenovo_led_brightness_set;
834+
data->led_micmute.max_brightness = 1;
833835
data->led_micmute.flags = LED_HW_PLUGGABLE;
834836
data->led_micmute.dev = &hdev->dev;
835837
ret = led_classdev_register(&hdev->dev, &data->led_micmute);

0 commit comments

Comments
 (0)