Skip to content

Commit 8cdc71f

Browse files
committed
KVM: selftests: Print timer ctl register in ISTATUS assertion
Zenghui noted that the test assertion for the ISTATUS bit is printing the current timer value instead of the control register in the case of failure. While the assertion is sound, printing CNT isn't informative. Change things around to actually print the CTL register value instead. Reported-by: Zenghui Yu <yuzenghui@huawei.com> Closes: https://lore.kernel.org/kvmarm/3188e6f1-f150-f7d0-6c2b-5b7608b0b012@huawei.com/ Reviewed-by: Zenghui Yu <zenghui.yu@linux.dev> Link: https://lore.kernel.org/r/20240212210932.3095265-2-oliver.upton@linux.dev Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
1 parent 06fdd89 commit 8cdc71f

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/testing/selftests/kvm/aarch64/arch_timer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ static void guest_validate_irq(unsigned int intid,
160160
__GUEST_ASSERT(xcnt >= cval,
161161
"xcnt = 0x%lx, cval = 0x%lx, xcnt_diff_us = 0x%lx",
162162
xcnt, cval, xcnt_diff_us);
163-
__GUEST_ASSERT(xctl & CTL_ISTATUS, "xcnt = 0x%lx", xcnt);
163+
__GUEST_ASSERT(xctl & CTL_ISTATUS, "xctl = 0x%lx", xctl);
164164

165165
WRITE_ONCE(shared_data->nr_iter, shared_data->nr_iter + 1);
166166
}

0 commit comments

Comments
 (0)