Skip to content

Commit 8e8aa07

Browse files
cristiccvinodkoul
authored andcommitted
phy: rockchip: samsung-hdptx: Enable lane output in common helper
In preparation to support FRL mode, move the PHY lane output enablement from the TMDS specific configuration to the common *_post_enable_lane() helper and make sure it gets turned off in *_phy_disable(). Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> Link: https://patch.msgid.link/20260113-phy-hdptx-frl-v6-5-8d5f97419c0b@collabora.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 925f26a commit 8e8aa07

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -797,6 +797,8 @@ static int rk_hdptx_post_enable_lane(struct rk_hdptx_phy *hdptx)
797797
HDPTX_I_BIAS_EN | HDPTX_I_BGR_EN;
798798
regmap_write(hdptx->grf, GRF_HDPTX_CON0, val);
799799

800+
regmap_write(hdptx->regmap, LNTOP_REG(0207), 0x0f);
801+
800802
ret = regmap_read_poll_timeout(hdptx->grf, GRF_HDPTX_STATUS, val,
801803
(val & HDPTX_O_PHY_RDY) &&
802804
(val & HDPTX_O_PLL_LOCK_DONE),
@@ -850,6 +852,7 @@ static void rk_hdptx_phy_disable(struct rk_hdptx_phy *hdptx)
850852
usleep_range(20, 30);
851853
reset_control_deassert(hdptx->rsts[RST_APB].rstc);
852854

855+
regmap_write(hdptx->regmap, LNTOP_REG(0207), 0x0);
853856
regmap_write(hdptx->regmap, LANE_REG(0300), 0x82);
854857
regmap_write(hdptx->regmap, SB_REG(010f), 0xc1);
855858
regmap_write(hdptx->regmap, SB_REG(0110), 0x1);
@@ -1027,7 +1030,6 @@ static int rk_hdptx_tmds_ropll_mode_config(struct rk_hdptx_phy *hdptx)
10271030
}
10281031

10291032
regmap_write(hdptx->regmap, LNTOP_REG(0206), 0x07);
1030-
regmap_write(hdptx->regmap, LNTOP_REG(0207), 0x0f);
10311033

10321034
rk_hdptx_multi_reg_write(hdptx, rk_hdptx_common_lane_init_seq);
10331035
rk_hdptx_multi_reg_write(hdptx, rk_hdptx_tmds_lane_init_seq);

0 commit comments

Comments
 (0)