clocksource/drivers/timer-ti-dm: Improve error message in .remove

Uwe Kleine-König · dlezcano · commit 8efcbe927c51 · 2023-04-24T16:56:13.000+02:00
If a platform driver's remove callback returns an error code, the driver core emits a generic (and thus little helpful) error message. Instead emit a more specifc error message about the actual error and return zero to suppress the core's message. Note that returning zero has no side effects apart from not emitting said error message. This prepares converting platform driver's remove message to return void. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/20230313075430.2730803-4-u.kleine-koenig@pengutronix.de
diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
@@ -1197,7 +1197,10 @@ static int omap_dm_timer_remove(struct platform_device *pdev)
 
 	pm_runtime_disable(&pdev->dev);
 
-	return ret;
+	if (ret)
+		dev_err(&pdev->dev, "Unable to determine timer entry in list of drivers on remove\n");
+
+	return 0;
 }
 
 static const struct omap_dm_timer_ops dmtimer_ops = {

Original file line number	Diff line number	Diff line change
`@@ -1197,7 +1197,10 @@ static int omap_dm_timer_remove(struct platform_device *pdev)`
`1197`	`1197`
`1198`	`1198`	`pm_runtime_disable(&pdev->dev);`
`1199`	`1199`
`1200`		`- return ret;`
	`1200`	`+ if (ret)`
	`1201`	`+ dev_err(&pdev->dev, "Unable to determine timer entry in list of drivers on remove\n");`
	`1202`	`+`
	`1203`	`+ return 0;`
`1201`	`1204`	`}`
`1202`	`1205`
`1203`	`1206`	`static const struct omap_dm_timer_ops dmtimer_ops = {`