Skip to content

Commit ede38f9

Browse files
Uwe Kleine-Königdlezcano
authored andcommitted
clocksource/drivers/timer-stm32-lp: Mark driver as non-removable
The comment in the remove callback suggests that the driver is not supposed to be unbound. However returning an error code in the remove callback doesn't accomplish that. Instead set the suppress_bind_attrs property (which makes it impossible to unbind the driver via sysfs). The only remaining way to unbind an stm32-lp device would be module unloading, but that doesn't apply here, as the driver cannot be built as a module. Also drop the useless remove callback. [dlezcano] : Fixed up the wrong function removed Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/20230313075430.2730803-3-u.kleine-koenig@pengutronix.de
1 parent 78012e3 commit ede38f9

1 file changed

Lines changed: 2 additions & 7 deletions

File tree

drivers/clocksource/timer-stm32-lp.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -195,23 +195,18 @@ static int stm32_clkevent_lp_probe(struct platform_device *pdev)
195195
return ret;
196196
}
197197

198-
static int stm32_clkevent_lp_remove(struct platform_device *pdev)
199-
{
200-
return -EBUSY; /* cannot unregister clockevent */
201-
}
202-
203198
static const struct of_device_id stm32_clkevent_lp_of_match[] = {
204199
{ .compatible = "st,stm32-lptimer-timer", },
205200
{},
206201
};
207202
MODULE_DEVICE_TABLE(of, stm32_clkevent_lp_of_match);
208203

209204
static struct platform_driver stm32_clkevent_lp_driver = {
210-
.probe = stm32_clkevent_lp_probe,
211-
.remove = stm32_clkevent_lp_remove,
205+
.probe = stm32_clkevent_lp_probe,
212206
.driver = {
213207
.name = "stm32-lptimer-timer",
214208
.of_match_table = of_match_ptr(stm32_clkevent_lp_of_match),
209+
.suppress_bind_attrs = true,
215210
},
216211
};
217212
module_platform_driver(stm32_clkevent_lp_driver);

0 commit comments

Comments
 (0)