Skip to content

Commit 9200f20

Browse files
Marek Vasutbjorn-helgaas
authored andcommitted
PCI: xilinx-xdma: Silence 'set affinity failed' warning
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows migrate_one_irq() to exit right away, without warnings like this: IRQ...: set affinity failed(-22) Remove the .irq_set_affinity() implementation that is no longer needed. Link: https://lore.kernel.org/r/20240723132958.41320-15-marek.vasut+renesas@mailbox.org Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> [bhelgaas: commit log] Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Acked-by: Thomas Gleixner <tglx@linutronix.de>
1 parent d5bba5b commit 9200f20

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

drivers/pci/controller/pcie-xilinx-dma-pl.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -355,8 +355,8 @@ static struct irq_chip xilinx_msi_irq_chip = {
355355
};
356356

357357
static struct msi_domain_info xilinx_msi_domain_info = {
358-
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
359-
MSI_FLAG_MULTI_PCI_MSI),
358+
.flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
359+
MSI_FLAG_NO_AFFINITY | MSI_FLAG_MULTI_PCI_MSI,
360360
.chip = &xilinx_msi_irq_chip,
361361
};
362362

@@ -370,16 +370,9 @@ static void xilinx_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
370370
msg->data = data->hwirq;
371371
}
372372

373-
static int xilinx_msi_set_affinity(struct irq_data *irq_data,
374-
const struct cpumask *mask, bool force)
375-
{
376-
return -EINVAL;
377-
}
378-
379373
static struct irq_chip xilinx_irq_chip = {
380374
.name = "pl_dma:MSI",
381375
.irq_compose_msi_msg = xilinx_compose_msi_msg,
382-
.irq_set_affinity = xilinx_msi_set_affinity,
383376
};
384377

385378
static int xilinx_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,

0 commit comments

Comments
 (0)