Skip to content

Commit d5bba5b

Browse files
Marek Vasutbjorn-helgaas
authored andcommitted
PCI: xilinx-nwl: Silence 'set affinity failed' warning
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows migrate_one_irq() to exit right away, without warnings like this: IRQ...: set affinity failed(-22) Remove the .irq_set_affinity() implementation that is no longer needed. Link: https://lore.kernel.org/r/20240723132958.41320-14-marek.vasut+renesas@mailbox.org Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> [bhelgaas: commit log] Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Acked-by: Thomas Gleixner <tglx@linutronix.de>
1 parent 647e965 commit d5bba5b

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

drivers/pci/controller/pcie-xilinx-nwl.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -425,8 +425,8 @@ static struct irq_chip nwl_msi_irq_chip = {
425425
};
426426

427427
static struct msi_domain_info nwl_msi_domain_info = {
428-
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
429-
MSI_FLAG_MULTI_PCI_MSI),
428+
.flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
429+
MSI_FLAG_NO_AFFINITY | MSI_FLAG_MULTI_PCI_MSI,
430430
.chip = &nwl_msi_irq_chip,
431431
};
432432
#endif
@@ -441,16 +441,9 @@ static void nwl_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
441441
msg->data = data->hwirq;
442442
}
443443

444-
static int nwl_msi_set_affinity(struct irq_data *irq_data,
445-
const struct cpumask *mask, bool force)
446-
{
447-
return -EINVAL;
448-
}
449-
450444
static struct irq_chip nwl_irq_chip = {
451445
.name = "Xilinx MSI",
452446
.irq_compose_msi_msg = nwl_compose_msi_msg,
453-
.irq_set_affinity = nwl_msi_set_affinity,
454447
};
455448

456449
static int nwl_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,

0 commit comments

Comments
 (0)