Skip to content

Commit 93822f5

Browse files
peckato1groeck
authored andcommitted
hwmon: (pmbus/fsp-3y) Fix functionality bitmask in FSP-3Y YM-2151E
The bit flags in pmbus_driver_info functionality for YM-2151E chip were joined with a comma operator instead of a bitwise OR. This means that the last constant PMBUS_HAVE_IIN was not OR-ed with the other PM_BUS_HAVE_* constants for this page but it initialized the next element of the func array (which was not accessed from anywhere because of the number of pages). However, there is no need for setting PMBUS_HAVE_IIN in the 5Vsb page because this command does not seem to be paged. Obviously, the device only has one IIN sensor, so it doesn't make sense to query it again from the second page. Fixes: 1734b41 ("hwmon: Add driver for fsp-3y PSUs and PDUs") Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz> Signed-off-by: Tomáš Pecka <tomas.pecka@cesnet.cz> Link: https://lore.kernel.org/r/20230420171939.212040-1-tomas.pecka@cesnet.cz Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent 2a8e41a commit 93822f5

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/hwmon/pmbus/fsp-3y.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,6 @@ static struct pmbus_driver_info fsp3y_info[] = {
180180
PMBUS_HAVE_FAN12,
181181
.func[YM2151_PAGE_5VSB_LOG] =
182182
PMBUS_HAVE_VOUT | PMBUS_HAVE_IOUT,
183-
PMBUS_HAVE_IIN,
184183
.read_word_data = fsp3y_read_word_data,
185184
.read_byte_data = fsp3y_read_byte_data,
186185
},

0 commit comments

Comments
 (0)