Skip to content

Commit 9b0f510

Browse files
hkallweitkuba-moo
authored andcommitted
lan78xx: remove redundant statement in lan78xx_get_eee
eee_active is set by phy_ethtool_get_eee() already, using the same logic plus an additional check against link speed/duplex values. See genphy_c45_eee_is_active() for details. So we can remove this line. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Link: https://lore.kernel.org/r/b086b296-0a1b-42d4-8e2b-ef6682598185@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 5733d13 commit 9b0f510

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/net/usb/lan78xx.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1691,8 +1691,6 @@ static int lan78xx_get_eee(struct net_device *net, struct ethtool_eee *edata)
16911691
ret = lan78xx_read_reg(dev, MAC_CR, &buf);
16921692
if (buf & MAC_CR_EEE_EN_) {
16931693
edata->eee_enabled = true;
1694-
edata->eee_active = !!(edata->advertised &
1695-
edata->lp_advertised);
16961694
edata->tx_lpi_enabled = true;
16971695
/* EEE_TX_LPI_REQ_DLY & tx_lpi_timer are same uSec unit */
16981696
ret = lan78xx_read_reg(dev, EEE_TX_LPI_REQ_DLY, &buf);

0 commit comments

Comments
 (0)