Skip to content

Commit 9c73576

Browse files
committed
media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit message (Miguel) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Sam Ravnborg <sam@ravnborg.org> Cc: Andy Walls <awalls@md.metrocast.net> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Hans Verkuil <hverkuil@xs4all.nl> Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-12-tzimmermann@suse.de
1 parent 8bf3ea7 commit 9c73576

2 files changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/media/pci/ivtv/ivtvfb.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1048,7 +1048,6 @@ static int ivtvfb_init_vidmode(struct ivtv *itv)
10481048
/* Generate valid fb_info */
10491049

10501050
oi->ivtvfb_info.node = -1;
1051-
oi->ivtvfb_info.flags = FBINFO_FLAG_DEFAULT;
10521051
oi->ivtvfb_info.par = itv;
10531052
oi->ivtvfb_info.var = oi->ivtvfb_defined;
10541053
oi->ivtvfb_info.fix = oi->ivtvfb_fix;

drivers/media/test-drivers/vivid/vivid-osd.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,6 @@ static int vivid_fb_init_vidmode(struct vivid_dev *dev)
310310
/* Generate valid fb_info */
311311

312312
dev->fb_info.node = -1;
313-
dev->fb_info.flags = FBINFO_FLAG_DEFAULT;
314313
dev->fb_info.par = dev;
315314
dev->fb_info.var = dev->fb_defined;
316315
dev->fb_info.fix = dev->fb_fix;

0 commit comments

Comments
 (0)