ALSA: fireface: make read-only const array for model names static

takaswie · tiwai · commit a64db0b9dfac · 2023-06-28T11:42:55.000+02:00
It is preferable not to populate the constant array for constant strings on the stack. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Link: https://lore.kernel.org/r/20230627235406.289970-1-o-takashi@sakamocchi.jp Signed-off-by: Takashi Iwai <tiwai@suse.de>
diff --git a/sound/firewire/fireface/ff.c b/sound/firewire/fireface/ff.c
@@ -16,7 +16,7 @@ MODULE_LICENSE("GPL");
 static void name_card(struct snd_ff *ff)
 {
 	struct fw_device *fw_dev = fw_parent_device(ff->unit);
-	const char *const names[] = {
+	static const char *const names[] = {
 		[SND_FF_UNIT_VERSION_FF800]	= "Fireface800",
 		[SND_FF_UNIT_VERSION_FF400]	= "Fireface400",
 		[SND_FF_UNIT_VERSION_UFX]	= "FirefaceUFX",

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ MODULE_LICENSE("GPL");`
`16`	`16`	`static void name_card(struct snd_ff *ff)`
`17`	`17`	`{`
`18`	`18`	`struct fw_device *fw_dev = fw_parent_device(ff->unit);`
`19`		`- const char *const names[] = {`
	`19`	`+ static const char *const names[] = {`
`20`	`20`	`[SND_FF_UNIT_VERSION_FF800] = "Fireface800",`
`21`	`21`	`[SND_FF_UNIT_VERSION_FF400] = "Fireface400",`
`22`	`22`	`[SND_FF_UNIT_VERSION_UFX] = "FirefaceUFX",`