Skip to content

Commit a76f8dc

Browse files
Dafna Hirschfeldmchehab
authored andcommitted
media: rkisp1: stats: remove a wrong cast to u8
hist_bins is an array of type __u32. Each entry represent a 20 bit fixed point value as documented inline. The cast to u8 when setting the values is wrong. Remove it. Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Reviewed-by: Heiko Stuebner <heiko@sntech.de> Acked-by: Helen Koike <helen.koike@collabora.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
1 parent 31f190e commit a76f8dc

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,8 +235,7 @@ static void rkisp1_stats_get_hst_meas(struct rkisp1_stats *stats,
235235
pbuf->meas_type |= RKISP1_CIF_ISP_STAT_HIST;
236236
for (i = 0; i < RKISP1_CIF_ISP_HIST_BIN_N_MAX; i++)
237237
pbuf->params.hist.hist_bins[i] =
238-
(u8)rkisp1_read(rkisp1,
239-
RKISP1_CIF_ISP_HIST_BIN_0 + i * 4);
238+
rkisp1_read(rkisp1, RKISP1_CIF_ISP_HIST_BIN_0 + i * 4);
240239
}
241240

242241
static void rkisp1_stats_get_bls_meas(struct rkisp1_stats *stats,

0 commit comments

Comments
 (0)