Skip to content

Commit abd9b9d

Browse files
Marek Vasutbjorn-helgaas
authored andcommitted
PCI: xilinx: Silence 'set affinity failed' warning
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows migrate_one_irq() to exit right away, without warnings like this: IRQ...: set affinity failed(-22) Remove the .irq_set_affinity() implementation that is no longer needed. Link: https://lore.kernel.org/r/20240723132958.41320-16-marek.vasut+renesas@mailbox.org Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> [bhelgaas: commit log] Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Acked-by: Thomas Gleixner <tglx@linutronix.de>
1 parent 9200f20 commit abd9b9d

1 file changed

Lines changed: 2 additions & 7 deletions

File tree

drivers/pci/controller/pcie-xilinx.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -208,11 +208,6 @@ static struct irq_chip xilinx_msi_top_chip = {
208208
.irq_ack = xilinx_msi_top_irq_ack,
209209
};
210210

211-
static int xilinx_msi_set_affinity(struct irq_data *d, const struct cpumask *mask, bool force)
212-
{
213-
return -EINVAL;
214-
}
215-
216211
static void xilinx_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
217212
{
218213
struct xilinx_pcie *pcie = irq_data_get_irq_chip_data(data);
@@ -225,7 +220,6 @@ static void xilinx_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
225220

226221
static struct irq_chip xilinx_msi_bottom_chip = {
227222
.name = "Xilinx MSI",
228-
.irq_set_affinity = xilinx_msi_set_affinity,
229223
.irq_compose_msi_msg = xilinx_compose_msi_msg,
230224
};
231225

@@ -271,7 +265,8 @@ static const struct irq_domain_ops xilinx_msi_domain_ops = {
271265
};
272266

273267
static struct msi_domain_info xilinx_msi_info = {
274-
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS),
268+
.flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
269+
MSI_FLAG_NO_AFFINITY,
275270
.chip = &xilinx_msi_top_chip,
276271
};
277272

0 commit comments

Comments
 (0)