Skip to content

Commit b2b6fa6

Browse files
superm1jwrdegoede
authored andcommitted
platform/x86/amd/pmf: Fix a suspend hang on Framework 13
The buffer is cleared in the suspend handler but used in the delayed work for amd_pmf_get_metrics(). Stop clearing it to fix the hang. Reported-by: Trolli Schmittlauch <t.schmittlauch@orlives.de> Closes: https://lore.kernel.org/regressions/ed2226ff-257b-4cfd-afd6-bf3be9785474@localhost/ Closes: https://community.frame.work/t/kernel-6-8-rc-system-freezes-after-resuming-from-suspend-reproducers-wanted/45381 Fixes: 2b3a7f0 ("platform/x86/amd/pmf: Change return type of amd_pmf_set_dram_addr()") Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Link: https://lore.kernel.org/r/20240217005216.113408-1-mario.limonciello@amd.com Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent 11e298f commit b2b6fa6

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

  • drivers/platform/x86/amd/pmf

drivers/platform/x86/amd/pmf/core.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,8 +299,6 @@ static int amd_pmf_suspend_handler(struct device *dev)
299299
if (pdev->smart_pc_enabled)
300300
cancel_delayed_work_sync(&pdev->pb_work);
301301

302-
kfree(pdev->buf);
303-
304302
return 0;
305303
}
306304

0 commit comments

Comments
 (0)