Skip to content

Commit b6f2f03

Browse files
tititiou36vinodkoul
authored andcommitted
dmaengine: idxd: Remove useless DMA-32 fallback configuration
As stated in [1], dma_set_mask() with a 64-bit mask never fails if dev->dma_mask is non-NULL. So, if it fails, the 32 bits case will also fail for the same reason. Simplify code and remove some dead code accordingly. [1]: https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Acked-by: Dave Jiang <dave.jiang@intel.com> Link: https://lore.kernel.org/r/009c80294dba72858cd8a6ed2ed81041df1b1e82.1642231430.git.christophe.jaillet@wanadoo.fr Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 8f7cc63 commit b6f2f03

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/dma/idxd/init.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -604,8 +604,6 @@ static int idxd_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
604604

605605
dev_dbg(dev, "Set DMA masks\n");
606606
rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
607-
if (rc)
608-
rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
609607
if (rc)
610608
goto err;
611609

0 commit comments

Comments
 (0)