Skip to content

Commit b918bfc

Browse files
committed
svcrdma: Remove queue-shortening warnings
These won't have much diagnostic value for site administrators. Since they can't be disabled, they become noise. What's more, the subsequent rdma_create_qp() call adjusts the Send Queue size (possibly downward) without warning, making the size reported by these pr_warns inaccurate. Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent 913cd76 commit b918bfc

1 file changed

Lines changed: 1 addition & 6 deletions

File tree

net/sunrpc/xprtrdma/svc_rdma_transport.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -412,8 +412,6 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt)
412412
rq_depth = newxprt->sc_max_requests + newxprt->sc_max_bc_requests +
413413
newxprt->sc_recv_batch;
414414
if (rq_depth > dev->attrs.max_qp_wr) {
415-
pr_warn("svcrdma: reducing receive depth to %d\n",
416-
dev->attrs.max_qp_wr);
417415
rq_depth = dev->attrs.max_qp_wr;
418416
newxprt->sc_recv_batch = 1;
419417
newxprt->sc_max_requests = rq_depth - 2;
@@ -423,11 +421,8 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt)
423421
ctxts = rdma_rw_mr_factor(dev, newxprt->sc_port_num, RPCSVC_MAXPAGES);
424422
ctxts *= newxprt->sc_max_requests;
425423
newxprt->sc_sq_depth = rq_depth + ctxts;
426-
if (newxprt->sc_sq_depth > dev->attrs.max_qp_wr) {
427-
pr_warn("svcrdma: reducing send depth to %d\n",
428-
dev->attrs.max_qp_wr);
424+
if (newxprt->sc_sq_depth > dev->attrs.max_qp_wr)
429425
newxprt->sc_sq_depth = dev->attrs.max_qp_wr;
430-
}
431426
atomic_set(&newxprt->sc_sq_avail, newxprt->sc_sq_depth);
432427

433428
newxprt->sc_pd = ib_alloc_pd(dev, 0);

0 commit comments

Comments
 (0)