Skip to content

Commit bb1b0e6

Browse files
committed
clk: x86: cgu: convert from divider_round_rate() to divider_determine_rate()
The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate = divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: f7a6bed ("clk: x86: cgu: convert from round_rate() to determine_rate()") Signed-off-by: Brian Masney <bmasney@redhat.com>
1 parent 56c1cfb commit bb1b0e6

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/clk/x86/clk-cgu.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,8 @@ static int lgm_clk_divider_determine_rate(struct clk_hw *hw,
137137
{
138138
struct lgm_clk_divider *divider = to_lgm_clk_divider(hw);
139139

140-
req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate, divider->table,
141-
divider->width, divider->flags);
142-
143-
return 0;
140+
return divider_determine_rate(hw, req, divider->table, divider->width,
141+
divider->flags);
144142
}
145143

146144
static int

0 commit comments

Comments
 (0)