Skip to content

Commit c1e4d3a

Browse files
nfrapradorobertfoss
authored andcommitted
drm/panel: truly-nt35597: Don't log an error when DSI host can't be found
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Signed-off-by: Robert Foss <rfoss@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240415-anx7625-defer-log-no-dsi-host-v3-9-619a28148e5c@collabora.com
1 parent 5ff5505 commit c1e4d3a

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/gpu/drm/panel/panel-truly-nt35597.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -550,10 +550,8 @@ static int truly_nt35597_probe(struct mipi_dsi_device *dsi)
550550

551551
dsi1_host = of_find_mipi_dsi_host_by_node(dsi1);
552552
of_node_put(dsi1);
553-
if (!dsi1_host) {
554-
dev_err(dev, "failed to find dsi host\n");
555-
return -EPROBE_DEFER;
556-
}
553+
if (!dsi1_host)
554+
return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n");
557555

558556
/* register the second DSI device */
559557
dsi1_device = mipi_dsi_device_register_full(dsi1_host, &info);

0 commit comments

Comments
 (0)