Skip to content

Commit c7b10ed

Browse files
Marek Vasutbjorn-helgaas
authored andcommitted
PCI: brcmstb: Silence 'set affinity failed' warning
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows migrate_one_irq() to exit right away, without warnings like this: IRQ...: set affinity failed(-22) Remove the .irq_set_affinity() implementation that is no longer needed. Link: https://lore.kernel.org/r/20240723132958.41320-5-marek.vasut+renesas@mailbox.org Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> [bhelgaas: commit log] Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Acked-by: Thomas Gleixner <tglx@linutronix.de>
1 parent 114ca29 commit c7b10ed

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

drivers/pci/controller/pcie-brcmstb.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -445,8 +445,8 @@ static struct irq_chip brcm_msi_irq_chip = {
445445
};
446446

447447
static struct msi_domain_info brcm_msi_domain_info = {
448-
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
449-
MSI_FLAG_MULTI_PCI_MSI),
448+
.flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
449+
MSI_FLAG_NO_AFFINITY | MSI_FLAG_MULTI_PCI_MSI,
450450
.chip = &brcm_msi_irq_chip,
451451
};
452452

@@ -484,12 +484,6 @@ static void brcm_msi_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
484484
msg->data = (0xffff & PCIE_MISC_MSI_DATA_CONFIG_VAL_32) | data->hwirq;
485485
}
486486

487-
static int brcm_msi_set_affinity(struct irq_data *irq_data,
488-
const struct cpumask *mask, bool force)
489-
{
490-
return -EINVAL;
491-
}
492-
493487
static void brcm_msi_ack_irq(struct irq_data *data)
494488
{
495489
struct brcm_msi *msi = irq_data_get_irq_chip_data(data);
@@ -502,7 +496,6 @@ static void brcm_msi_ack_irq(struct irq_data *data)
502496
static struct irq_chip brcm_msi_bottom_irq_chip = {
503497
.name = "BRCM STB MSI",
504498
.irq_compose_msi_msg = brcm_msi_compose_msi_msg,
505-
.irq_set_affinity = brcm_msi_set_affinity,
506499
.irq_ack = brcm_msi_ack_irq,
507500
};
508501

0 commit comments

Comments
 (0)