Skip to content

Commit cd8967e

Browse files
QSchulzmmind
authored andcommitted
arm64: dts: rockchip: fix unit-address for RK3588 NPU's core1 and core2's IOMMU
The Device Tree specification specifies[1] that """ Each node in the devicetree is named according to the following convention: node-name@unit-address [...] The unit-address must match the first address specified in the reg property of the node. """ The first address in the reg property is fdaXa000 and not fdaX9000. This is likely a copy-paste error as the IOMMU for core0 has two entries in the reg property, the first one being fdab9000 and the second fdaba000. Let's fix this oversight to match what the spec is expecting. [1] https://github.com/devicetree-org/devicetree-specification/releases/download/v0.4/devicetree-specification-v0.4.pdf 2.2.1 Node Names Fixes: a31dfc0 ("arm64: dts: rockchip: Add nodes for NPU and its MMU to rk3588-base") Cc: stable@vger.kernel.org Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> Link: https://patch.msgid.link/20251215-npu-dt-node-address-v1-1-840093e8a2bf@cherry.de Signed-off-by: Heiko Stuebner <heiko@sntech.de>
1 parent 7c6bbcb commit cd8967e

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

arch/arm64/boot/dts/rockchip/rk3588-base.dtsi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1200,7 +1200,7 @@
12001200
status = "disabled";
12011201
};
12021202

1203-
rknn_mmu_1: iommu@fdac9000 {
1203+
rknn_mmu_1: iommu@fdaca000 {
12041204
compatible = "rockchip,rk3588-iommu", "rockchip,rk3568-iommu";
12051205
reg = <0x0 0xfdaca000 0x0 0x100>;
12061206
interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH 0>;
@@ -1230,7 +1230,7 @@
12301230
status = "disabled";
12311231
};
12321232

1233-
rknn_mmu_2: iommu@fdad9000 {
1233+
rknn_mmu_2: iommu@fdada000 {
12341234
compatible = "rockchip,rk3588-iommu", "rockchip,rk3568-iommu";
12351235
reg = <0x0 0xfdada000 0x0 0x100>;
12361236
interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH 0>;

0 commit comments

Comments
 (0)