Skip to content

Commit cda5dc1

Browse files
Dan Carpenterandersson
authored andcommitted
remoteproc: qcom_wcnss: Fix NULL vs IS_ERR() bug in wcnss_alloc_memory_region()
The devm_ioremap_resource_wc() function never returns NULL, it returns error pointers. Update the checking to match. Fixes: c70b9d5 ("remoteproc: qcom: Use of_reserved_mem_region_* functions for "memory-region"") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/09a43da41ee277a80a3265348831e747f7b62620.1764427595.git.dan.carpenter@linaro.org Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent cb200e4 commit cda5dc1

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/remoteproc/qcom_wcnss.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -538,9 +538,9 @@ static int wcnss_alloc_memory_region(struct qcom_wcnss *wcnss)
538538
wcnss->mem_phys = wcnss->mem_reloc = res.start;
539539
wcnss->mem_size = resource_size(&res);
540540
wcnss->mem_region = devm_ioremap_resource_wc(wcnss->dev, &res);
541-
if (!wcnss->mem_region) {
541+
if (IS_ERR(wcnss->mem_region)) {
542542
dev_err(wcnss->dev, "unable to map memory region: %pR\n", &res);
543-
return -EBUSY;
543+
return PTR_ERR(wcnss->mem_region);
544544
}
545545

546546
return 0;

0 commit comments

Comments
 (0)