Skip to content

Commit cdeb052

Browse files
committed
staging: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit message (Miguel) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Sam Ravnborg <sam@ravnborg.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Cc: Teddy Wang <teddy.wang@siliconmotion.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-13-tzimmermann@suse.de
1 parent 9c73576 commit cdeb052

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/staging/fbtft/fbtft-core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -684,7 +684,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,
684684
info->var.transp.offset = 0;
685685
info->var.transp.length = 0;
686686

687-
info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB;
687+
info->flags = FBINFO_VIRTFB;
688688

689689
par = info->par;
690690
par->info = info;

drivers/staging/sm750fb/sm750.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -807,7 +807,6 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
807807
info->screen_base = crtc->v_screen;
808808
pr_debug("screen_base vaddr = %p\n", info->screen_base);
809809
info->screen_size = line_length * var->yres_virtual;
810-
info->flags = FBINFO_FLAG_DEFAULT | 0;
811810

812811
/* set info->fix */
813812
fix->type = FB_TYPE_PACKED_PIXELS;

0 commit comments

Comments
 (0)