Skip to content

Commit d6ba734

Browse files
Carlos Llamasgregkh
authored andcommitted
rust_binderfs: fix ida_alloc_max() upper bound
The 'max' argument of ida_alloc_max() takes the maximum valid ID and not the "count". Using an ID of BINDERFS_MAX_MINOR (1 << 20) for dev->minor would exceed the limits of minor numbers (20-bits). Fix this off-by-one error by subtracting 1 from the 'max'. Cc: stable@vger.kernel.org Fixes: eafedbc ("rust_binder: add Rust Binder driver") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/r/202512181203.IOv6IChH-lkp@intel.com/ Signed-off-by: Carlos Llamas <cmllamas@google.com> Reviewed-by: Alice Ryhl <aliceryhl@google.com> Link: https://patch.msgid.link/20260127235545.2307876-1-cmllamas@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 1769f90 commit d6ba734

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

drivers/android/binder/rust_binderfs.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,8 @@ static int binderfs_binder_device_create(struct inode *ref_inode,
132132
mutex_lock(&binderfs_minors_mutex);
133133
if (++info->device_count <= info->mount_opts.max)
134134
minor = ida_alloc_max(&binderfs_minors,
135-
use_reserve ? BINDERFS_MAX_MINOR :
136-
BINDERFS_MAX_MINOR_CAPPED,
135+
use_reserve ? BINDERFS_MAX_MINOR - 1 :
136+
BINDERFS_MAX_MINOR_CAPPED - 1,
137137
GFP_KERNEL);
138138
else
139139
minor = -ENOSPC;
@@ -405,8 +405,8 @@ static int binderfs_binder_ctl_create(struct super_block *sb)
405405
/* Reserve a new minor number for the new device. */
406406
mutex_lock(&binderfs_minors_mutex);
407407
minor = ida_alloc_max(&binderfs_minors,
408-
use_reserve ? BINDERFS_MAX_MINOR :
409-
BINDERFS_MAX_MINOR_CAPPED,
408+
use_reserve ? BINDERFS_MAX_MINOR - 1 :
409+
BINDERFS_MAX_MINOR_CAPPED - 1,
410410
GFP_KERNEL);
411411
mutex_unlock(&binderfs_minors_mutex);
412412
if (minor < 0) {

0 commit comments

Comments
 (0)