Skip to content

Commit d7b7642

Browse files
Uwe Kleine-Königdlezcano
authored andcommitted
clocksource/drivers/timer-tegra186: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/20230313075430.2730803-5-u.kleine-koenig@pengutronix.de
1 parent 8efcbe9 commit d7b7642

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/clocksource/timer-tegra186.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -447,15 +447,13 @@ static int tegra186_timer_probe(struct platform_device *pdev)
447447
return err;
448448
}
449449

450-
static int tegra186_timer_remove(struct platform_device *pdev)
450+
static void tegra186_timer_remove(struct platform_device *pdev)
451451
{
452452
struct tegra186_timer *tegra = platform_get_drvdata(pdev);
453453

454454
clocksource_unregister(&tegra->usec);
455455
clocksource_unregister(&tegra->osc);
456456
clocksource_unregister(&tegra->tsc);
457-
458-
return 0;
459457
}
460458

461459
static int __maybe_unused tegra186_timer_suspend(struct device *dev)
@@ -505,7 +503,7 @@ static struct platform_driver tegra186_wdt_driver = {
505503
.of_match_table = tegra186_timer_of_match,
506504
},
507505
.probe = tegra186_timer_probe,
508-
.remove = tegra186_timer_remove,
506+
.remove_new = tegra186_timer_remove,
509507
};
510508
module_platform_driver(tegra186_wdt_driver);
511509

0 commit comments

Comments
 (0)