Skip to content

Commit d8f1121

Browse files
Vladimir Zapolskiyandersson
authored andcommitted
clk: qcom: camcc-sm8550: Specify Titan GDSC power domain as a parent to other
When a consumer turns on/off a power domain dependent on another power domain in hardware, the parent power domain shall be turned on/off by the power domain provider as well, and to get it the power domain hardware hierarchy shall be described in the CAMCC driver. Establish the power domain hierarchy with a Titan GDSC set as a parent of all other GDSC power domains provided by the SM8550 camera clock controller to enforce a correct sequence of enabling and disabling power domains by the consumers, this fixes the CAMCC as a supplier of power domains to CAMSS IP and its driver. Fixes: ccc4e6a ("clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550") Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Reviewed-by: Imran Shaik <imran.shaik@oss.qualcomm.com> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> Link: https://lore.kernel.org/r/20251021234450.2271279-2-vladimir.zapolskiy@linaro.org Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent 8abe970 commit d8f1121

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

drivers/clk/qcom/camcc-sm8550.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3204,6 +3204,8 @@ static struct clk_branch cam_cc_sfe_1_fast_ahb_clk = {
32043204
},
32053205
};
32063206

3207+
static struct gdsc cam_cc_titan_top_gdsc;
3208+
32073209
static struct gdsc cam_cc_bps_gdsc = {
32083210
.gdscr = 0x10004,
32093211
.en_rest_wait_val = 0x2,
@@ -3213,6 +3215,7 @@ static struct gdsc cam_cc_bps_gdsc = {
32133215
.name = "cam_cc_bps_gdsc",
32143216
},
32153217
.pwrsts = PWRSTS_OFF_ON,
3218+
.parent = &cam_cc_titan_top_gdsc.pd,
32163219
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
32173220
};
32183221

@@ -3225,6 +3228,7 @@ static struct gdsc cam_cc_ife_0_gdsc = {
32253228
.name = "cam_cc_ife_0_gdsc",
32263229
},
32273230
.pwrsts = PWRSTS_OFF_ON,
3231+
.parent = &cam_cc_titan_top_gdsc.pd,
32283232
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
32293233
};
32303234

@@ -3237,6 +3241,7 @@ static struct gdsc cam_cc_ife_1_gdsc = {
32373241
.name = "cam_cc_ife_1_gdsc",
32383242
},
32393243
.pwrsts = PWRSTS_OFF_ON,
3244+
.parent = &cam_cc_titan_top_gdsc.pd,
32403245
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
32413246
};
32423247

@@ -3249,6 +3254,7 @@ static struct gdsc cam_cc_ife_2_gdsc = {
32493254
.name = "cam_cc_ife_2_gdsc",
32503255
},
32513256
.pwrsts = PWRSTS_OFF_ON,
3257+
.parent = &cam_cc_titan_top_gdsc.pd,
32523258
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
32533259
};
32543260

@@ -3261,6 +3267,7 @@ static struct gdsc cam_cc_ipe_0_gdsc = {
32613267
.name = "cam_cc_ipe_0_gdsc",
32623268
},
32633269
.pwrsts = PWRSTS_OFF_ON,
3270+
.parent = &cam_cc_titan_top_gdsc.pd,
32643271
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
32653272
};
32663273

@@ -3273,6 +3280,7 @@ static struct gdsc cam_cc_sbi_gdsc = {
32733280
.name = "cam_cc_sbi_gdsc",
32743281
},
32753282
.pwrsts = PWRSTS_OFF_ON,
3283+
.parent = &cam_cc_titan_top_gdsc.pd,
32763284
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
32773285
};
32783286

@@ -3285,6 +3293,7 @@ static struct gdsc cam_cc_sfe_0_gdsc = {
32853293
.name = "cam_cc_sfe_0_gdsc",
32863294
},
32873295
.pwrsts = PWRSTS_OFF_ON,
3296+
.parent = &cam_cc_titan_top_gdsc.pd,
32883297
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
32893298
};
32903299

@@ -3297,6 +3306,7 @@ static struct gdsc cam_cc_sfe_1_gdsc = {
32973306
.name = "cam_cc_sfe_1_gdsc",
32983307
},
32993308
.pwrsts = PWRSTS_OFF_ON,
3309+
.parent = &cam_cc_titan_top_gdsc.pd,
33003310
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
33013311
};
33023312

0 commit comments

Comments
 (0)