dmaengine: stm32-mdma: fix chan initialization in stm32_mdma_irq_handler()

ADESTM · vinodkoul · commit da3b8ddb464b · 2022-05-19T23:21:28.000+05:30
The parameter to pass back to the handler function when irq has been requested is a struct stm32_mdma_device pointer, not a struct stm32_mdma_chan pointer. Even if chan is reinit later in the function, remove this wrong initialization. Fixes: a4ffb13 ("dmaengine: Add STM32 MDMA driver") Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com> Link: https://lore.kernel.org/r/20220504155322.121431-3-amelie.delaunay@foss.st.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c
@@ -1318,7 +1318,7 @@ static void stm32_mdma_xfer_end(struct stm32_mdma_chan *chan)
 static irqreturn_t stm32_mdma_irq_handler(int irq, void *devid)
 {
 	struct stm32_mdma_device *dmadev = devid;
-	struct stm32_mdma_chan *chan = devid;
+	struct stm32_mdma_chan *chan;
 	u32 reg, id, ccr, ien, status;
 
 	/* Find out which channel generates the interrupt */

Original file line number	Diff line number	Diff line change
`@@ -1318,7 +1318,7 @@ static void stm32_mdma_xfer_end(struct stm32_mdma_chan *chan)`
`1318`	`1318`	`static irqreturn_t stm32_mdma_irq_handler(int irq, void *devid)`
`1319`	`1319`	`{`
`1320`	`1320`	`struct stm32_mdma_device *dmadev = devid;`
`1321`		`- struct stm32_mdma_chan *chan = devid;`
	`1321`	`+ struct stm32_mdma_chan *chan;`
`1322`	`1322`	`u32 reg, id, ccr, ien, status;`
`1323`	`1323`
`1324`	`1324`	`/* Find out which channel generates the interrupt */`