Skip to content

Commit e3affc7

Browse files
author
Lucas De Marchi
committed
drm/i915/gt: Also check set bits in clr_set()
When checking if the workarounds were applied successfully, the read-back mask should also contain the bits being set: it's possible that in a call to wa_write_clr_set(), the cleared bits are not a superset of the set bits. Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Link: https://patchwork.freedesktop.org/patch/msgid/20230630203509.1635216-8-lucas.demarchi@intel.com
1 parent 03286f9 commit e3affc7

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/gpu/drm/i915/gt/intel_workarounds.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,13 +241,13 @@ static void wa_mcr_add(struct i915_wa_list *wal, i915_mcr_reg_t reg,
241241
static void
242242
wa_write_clr_set(struct i915_wa_list *wal, i915_reg_t reg, u32 clear, u32 set)
243243
{
244-
wa_add(wal, reg, clear, set, clear, false);
244+
wa_add(wal, reg, clear, set, clear | set, false);
245245
}
246246

247247
static void
248248
wa_mcr_write_clr_set(struct i915_wa_list *wal, i915_mcr_reg_t reg, u32 clear, u32 set)
249249
{
250-
wa_mcr_add(wal, reg, clear, set, clear, false);
250+
wa_mcr_add(wal, reg, clear, set, clear | set, false);
251251
}
252252

253253
static void

0 commit comments

Comments
 (0)