PM: wakeup: remove redundant assignment to variable retval

Colin Ian King · rafaeljw · commit e48802333ace · 2021-04-22T15:22:38.000+02:00
The variable retval is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: Rafael J. Wysocki &lt;rafael.j.wysocki@intel.com&gt;
diff --git a/drivers/base/power/wakeup_stats.c b/drivers/base/power/wakeup_stats.c
@@ -137,7 +137,7 @@ static struct device *wakeup_source_device_create(struct device *parent,
 						  struct wakeup_source *ws)
 {
 	struct device *dev = NULL;
-	int retval = -ENODEV;
+	int retval;
 
 	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
 	if (!dev) {

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ static struct device wakeup_source_device_create(struct device parent,`
`137`	`137`	`struct wakeup_source *ws)`
`138`	`138`	`{`
`139`	`139`	`struct device *dev = NULL;`
`140`		`- int retval = -ENODEV;`
	`140`	`+ int retval;`
`141`	`141`
`142`	`142`	`dev = kzalloc(sizeof(*dev), GFP_KERNEL);`
`143`	`143`	`if (!dev) {`