Skip to content

Commit e702196

Browse files
mqqcrafaeljw
authored andcommitted
ACPI / x86: Work around broken XSDT on Advantech DAC-BJ01 board
On this board the ACPI RSDP structure points to both a RSDT and an XSDT, but the XSDT points to a truncated FADT. This causes all sorts of trouble and usually a complete failure to boot after the following error occurs: ACPI Error: Unsupported address space: 0x20 (*/hwregs-*) ACPI Error: AE_SUPPORT, Unable to initialize fixed events (*/evevent-*) ACPI: Unable to start ACPI Interpreter This leaves the ACPI implementation in such a broken state that subsequent kernel subsystem initialisations go wrong, resulting in among others mismapped PCI memory, SATA and USB enumeration failures, and freezes. As this is an older embedded platform that will likely never see any BIOS updates to address this issue and its default shipping OS only complies to ACPI 1.0, work around this by forcing `acpi=rsdt`. This patch, applied on top of Linux 5.10.102, was confirmed on real hardware to fix the issue. Signed-off-by: Mark Cilissen <mark@yotsuba.nl> Cc: All applicable <stable@vger.kernel.org> Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent eb5616d commit e702196

1 file changed

Lines changed: 24 additions & 0 deletions

File tree

arch/x86/kernel/acpi/boot.c

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1328,6 +1328,17 @@ static int __init disable_acpi_pci(const struct dmi_system_id *d)
13281328
return 0;
13291329
}
13301330

1331+
static int __init disable_acpi_xsdt(const struct dmi_system_id *d)
1332+
{
1333+
if (!acpi_force) {
1334+
pr_notice("%s detected: force use of acpi=rsdt\n", d->ident);
1335+
acpi_gbl_do_not_use_xsdt = TRUE;
1336+
} else {
1337+
pr_notice("Warning: DMI blacklist says broken, but acpi XSDT forced\n");
1338+
}
1339+
return 0;
1340+
}
1341+
13311342
static int __init dmi_disable_acpi(const struct dmi_system_id *d)
13321343
{
13331344
if (!acpi_force) {
@@ -1451,6 +1462,19 @@ static const struct dmi_system_id acpi_dmi_table[] __initconst = {
14511462
DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 360"),
14521463
},
14531464
},
1465+
/*
1466+
* Boxes that need ACPI XSDT use disabled due to corrupted tables
1467+
*/
1468+
{
1469+
.callback = disable_acpi_xsdt,
1470+
.ident = "Advantech DAC-BJ01",
1471+
.matches = {
1472+
DMI_MATCH(DMI_SYS_VENDOR, "NEC"),
1473+
DMI_MATCH(DMI_PRODUCT_NAME, "Bearlake CRB Board"),
1474+
DMI_MATCH(DMI_BIOS_VERSION, "V1.12"),
1475+
DMI_MATCH(DMI_BIOS_DATE, "02/01/2011"),
1476+
},
1477+
},
14541478
{}
14551479
};
14561480

0 commit comments

Comments
 (0)