Skip to content

Commit ed61187

Browse files
Uwe Kleine-Königmathieupoirier
authored andcommitted
remoteproc: rcar: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230504194453.1150368-15-u.kleine-koenig@pengutronix.de Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
1 parent 07336df commit ed61187

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/remoteproc/rcar_rproc.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -197,13 +197,11 @@ static int rcar_rproc_probe(struct platform_device *pdev)
197197
return ret;
198198
}
199199

200-
static int rcar_rproc_remove(struct platform_device *pdev)
200+
static void rcar_rproc_remove(struct platform_device *pdev)
201201
{
202202
struct device *dev = &pdev->dev;
203203

204204
pm_runtime_disable(dev);
205-
206-
return 0;
207205
}
208206

209207
static const struct of_device_id rcar_rproc_of_match[] = {
@@ -215,7 +213,7 @@ MODULE_DEVICE_TABLE(of, rcar_rproc_of_match);
215213

216214
static struct platform_driver rcar_rproc_driver = {
217215
.probe = rcar_rproc_probe,
218-
.remove = rcar_rproc_remove,
216+
.remove_new = rcar_rproc_remove,
219217
.driver = {
220218
.name = "rcar-rproc",
221219
.of_match_table = rcar_rproc_of_match,

0 commit comments

Comments
 (0)