Skip to content

Commit f5ee4cc

Browse files
committed
cxl/security: Fix Get Security State output payload endian handling
Multi-byte integer values in CXL mailbox payloads are little endian. Add a definition of the Get Security State output payload and convert the value before testing flags. Fixes: 3282811 ("cxl/pmem: Introduce nvdimm_security_ops with ->get_flags() operation") Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com> Cc: Dave Jiang <dave.jiang@intel.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Reviewed-by: Ira Weiny <ira.weiny@intel.com> Link: https://lore.kernel.org/r/167030054822.4044561.4917796262037689553.stgit@dwillia2-xfh.jf.intel.com Signed-off-by: Dan Williams <dan.j.williams@intel.com>
1 parent c99b2e8 commit f5ee4cc

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

drivers/cxl/security.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,18 @@ static unsigned long cxl_pmem_get_security_flags(struct nvdimm *nvdimm,
1616
struct cxl_memdev *cxlmd = cxl_nvd->cxlmd;
1717
struct cxl_dev_state *cxlds = cxlmd->cxlds;
1818
unsigned long security_flags = 0;
19+
struct cxl_get_security_output {
20+
__le32 flags;
21+
} out;
1922
u32 sec_out;
2023
int rc;
2124

2225
rc = cxl_mbox_send_cmd(cxlds, CXL_MBOX_OP_GET_SECURITY_STATE, NULL, 0,
23-
&sec_out, sizeof(sec_out));
26+
&out, sizeof(out));
2427
if (rc < 0)
2528
return 0;
2629

30+
sec_out = le32_to_cpu(out.flags);
2731
if (ptype == NVDIMM_MASTER) {
2832
if (sec_out & CXL_PMEM_SEC_STATE_MASTER_PASS_SET)
2933
set_bit(NVDIMM_SECURITY_UNLOCKED, &security_flags);

0 commit comments

Comments
 (0)