Skip to content

Commit f8ba14b

Browse files
KamilDuljasbroonie
authored andcommitted
ASoC: Intel: Skylake: mem leak in skl register function
skl_platform_register() uses krealloc. When krealloc is fail, then previous memory is not freed. The leak is also when soc component registration failed. Signed-off-by: Kamil Duljas <kamil.duljas@gmail.com> Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20231116224112.2209-2-kamil.duljas@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 31e721f commit f8ba14b

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

sound/soc/intel/skylake/skl-pcm.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1464,6 +1464,7 @@ int skl_platform_register(struct device *dev)
14641464
dais = krealloc(skl->dais, sizeof(skl_fe_dai) +
14651465
sizeof(skl_platform_dai), GFP_KERNEL);
14661466
if (!dais) {
1467+
kfree(skl->dais);
14671468
ret = -ENOMEM;
14681469
goto err;
14691470
}
@@ -1476,8 +1477,10 @@ int skl_platform_register(struct device *dev)
14761477

14771478
ret = devm_snd_soc_register_component(dev, &skl_component,
14781479
skl->dais, num_dais);
1479-
if (ret)
1480+
if (ret) {
1481+
kfree(skl->dais);
14801482
dev_err(dev, "soc component registration failed %d\n", ret);
1483+
}
14811484
err:
14821485
return ret;
14831486
}

0 commit comments

Comments
 (0)