Skip to content

Commit ff96e61

Browse files
Uwe Kleine-Königrafaeljw
authored andcommitted
thermal: k3_bandgap: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent a876f99 commit ff96e61

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/thermal/k3_bandgap.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -235,12 +235,10 @@ static int k3_bandgap_probe(struct platform_device *pdev)
235235
return ret;
236236
}
237237

238-
static int k3_bandgap_remove(struct platform_device *pdev)
238+
static void k3_bandgap_remove(struct platform_device *pdev)
239239
{
240240
pm_runtime_put_sync(&pdev->dev);
241241
pm_runtime_disable(&pdev->dev);
242-
243-
return 0;
244242
}
245243

246244
static const struct of_device_id of_k3_bandgap_match[] = {
@@ -253,7 +251,7 @@ MODULE_DEVICE_TABLE(of, of_k3_bandgap_match);
253251

254252
static struct platform_driver k3_bandgap_sensor_driver = {
255253
.probe = k3_bandgap_probe,
256-
.remove = k3_bandgap_remove,
254+
.remove_new = k3_bandgap_remove,
257255
.driver = {
258256
.name = "k3-soc-thermal",
259257
.of_match_table = of_k3_bandgap_match,

0 commit comments

Comments
 (0)