Skip to content

Prepare to change target logic #25

Closed

Description

@alex

If rust-lang/rust#77916 lands in upstream rust, we'll need to change the target we compile with. The new target makes more sense anyways :-)

Activity

  1. added
    • toolchainRelated to `rustc`, `bindgen`, `rustdoc`, LLVM, Clippy...
    on Oct 13, 2020
  2. ojeda commented on Oct 14, 2020

    @ojeda
    Member

    Yeah, although this shows why rustc should not need to have the target to begin with. Unless there is a reason not to, it is cleaner to have it on our end. That eliminates a dependency on a common name, resolves the "naming dispute" FIXME and avoids rustc having to track all possible targets out there. It seems like they might agree, so I supported that view in rust-lang/rust#74247

  3. Ericson2314 commented on Oct 15, 2020

    @Ericson2314

    I'm in now way official over there, to be clear, but yes you state my view exactly! I don't think these sorts of layer violations help anyone.

  4. ojeda commented on Nov 26, 2020

    @ojeda
    Member

    In #28 I go the route of having our own target spec.

  5. modified the milestone: on Jan 12, 2021
  6. alex commented on Jan 21, 2021

    @alex
    MemberAuthor

    @ojeda was this obsoleted by the switch to not use cargo?

  7. ojeda commented on Jan 21, 2021

    @ojeda
    Member

    It was obsoleted by #28 given we use custom targets, although I didn't close this given the discussions are ongoing e.g. see the overview I wrote yesterday at rust-lang/rust#71009. But changing the title or closing this and creating a new issue makes sense.

  8. alex commented on Jan 22, 2021

    @alex
    MemberAuthor

    I'm going to close this, given the precise original reason I filed it for has been obviated.

  9. 1 remaining item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    • toolchainRelated to `rustc`, `bindgen`, `rustdoc`, LLVM, Clippy...

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions