Repository navigation
Backport cpal 0.18.2 to the 0.22 release line - #930
Merged
yara-blue merged 3 commits intoOct 8, 2026
Merged
Conversation
Backport of the cpal 0.18 migration from master onto the 0.22 release line. The code changes are copied from master commits 174ce9b (RustAudio#866) and 049fbd3 (RustAudio#875). Cargo.lock is regenerated for cpal 0.18.2. The cpal requirement is 0.18.2 rather than master's 0.18, because the visionOS CoreAudio build fix landed in 0.18.2. Refs RustAudio#898
`clippy::question_mark` started flagging this in Rust 1.97, and CI runs clippy from stable with `-D warnings`, so the check now fails on master. (cherry picked from commit e1b6efe)
yara-blue
approved these changes
Oct 8, 2026
yara-blue
left a comment
yara-blue
left a comment
Member
There was a problem hiding this comment.
perfect thanks!
I'll cut a release soon. Please ping me if I fail to do so this weekend!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As agreed in #898: a backport of cpal 0.18 to the 0.22 release line, targeting
backport-cpal-0.18.The first commit updates cpal to 0.18.2. The code changes are copied from master, commits 174ce9b (#866) and 049fbd3 (#875), and
Cargo.lockis regenerated. In the migration code, the only difference from master is the requirementcpal = "0.18.2"instead of"0.18", because the CoreAudio build for visionOS was only fixed in 0.18.2, and visionOS is what this issue started with.The second commit adds a changelog entry under
Unreleasedand a section inUPGRADE.md. I didn't touch the version or the other release steps, I'm leaving those to you.The last commit is the one-line clippy 1.97 fix from #899, cherry-picked from master. The 0.22 release line predates it, and without it CI fails at the clippy step.
One thing to know: on this branch
Microphonestill ends on any stream error, including xruns, which cpal 0.18.2 now reports on more backends. I left that alone to keep this a straight copy of master. If you want, I can send a small separate fix.Tested: the full command set from
ci.ymlon Rust 1.87 with-D warnings, plus clippy, rustfmt and the nightly docs build.cargo +nightly check -Zbuild-std=std,panic_abort --target aarch64-apple-visionos --libfails on v0.22.2 and passes on this branch.Manually on macOS (CoreAudio): playback and recording through
Microphonework. A 440 Hz sine played through the BlackHole virtual device records back at the expected frequency and level, and the built-in microphone records too. I didn't test Linux or Windows on hardware.Refs #898