Repository navigation
Conversation
alpkom
requested changes
Oct 19, 2026
Comment on lines
+70
to
+71
| content: str = "" | ||
| signature: str = "" |
Contributor
There was a problem hiding this comment.
Shouldn't we define them as optional, if they're optional in the API spec?
Contributor
There was a problem hiding this comment.
Hmm, introducing Optional[str] type would be different from the spec or not?
Contributor
Author
There was a problem hiding this comment.
Not sure what the advantage would be. Now we have the following behaviour for the attributes (if I understand correctly):
- if we get a
str, then the attribute is populated with thatstr - if we don't get a value for the attribute, it is set to the default value ""
If we define content: Optional[str] = "", then again:
- if we get a
str, then the attribute is populated with thatstr - if we don't get a value for the attribute, it is set to the default value ""
- it could only be set to
Noneif the response explicitly contains a null value which according to the spec cannot happen
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does and why it is needed
There is a small gap to the orchestration spec due to missing defaults in
ReasoningBlock. This PR adds the default values.