Skip to content

chore(db2): bump db2-sqlglot-dialect minimum to 1.1.0 - #6170

Open
hdm-db2-eco-system wants to merge 1 commit into
SQLMesh:mainfrom
hdm-db2-eco-system:chore/db2-sqlglot-dialect-1.1.0
Open

hdm-db2-eco-system wants to merge 1 commit into
SQLMesh:mainfrom
hdm-db2-eco-system:chore/db2-sqlglot-dialect-1.1.0

Conversation

@hdm-db2-eco-system

@hdm-db2-eco-system hdm-db2-eco-system commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Version 1.1.0 fixes TYPE_MAPPING keys (exp.DType.* → exp.DataType.Type.*) and adds JSON_KEY_VALUE_PAIR_SEP = " VALUE" for correct Db2 JSON_OBJECT syntax. The SQLGlot dependency requirement is now >=30.8.0. No adapter code changes are required.

Verified: 213/213 tests pass with db2-sqlglot-dialect==1.1.0 on Python 3.12 and 3.13.

Description

Bumps the minimum version of db2-sqlglot-dialect to >=1.1.0 in the db2 extra to ensure compatibility with the updated SQLGlot API and Db2 SQL generation.

Test Plan

  • Ran python -m pytest tests/core/engine_adapter/test_db2.py tests/core/test_dialect.py -x -q.
  • Python 3.12: 213/213 tests passed.
  • Python 3.13: 213/213 tests passed.
  • make fast-test was not run locally because the full development installation is required. CI will run the full suite.

Checklist

  • I have run make style and fixed any issues (Ruff and Ruff Format passed; MyPy errors are pre-existing and unrelated).
  • I have added tests for my changes (N/A — no adapter code changes required).
  • All existing tests pass (make fast-test) — Db2-specific tests passed; full suite will run on CI.
  • My commits are signed off (git commit -s) per the [DCO](DCO).

Summary by CodeRabbit

  • Chores
    • Updated compatibility requirements for the optional DB2 integration on Python 3.10 and newer. Existing Python version conditions remain unchanged.
    • No changes to the app’s user-facing features or behavior are included in this update.

Version 1.1.0 fixes TYPE_MAPPING keys (exp.DType.* -> exp.DataType.Type.*)
and adds JSON_KEY_VALUE_PAIR_SEP for correct Db2 JSON_OBJECT syntax.
No adapter code changes required.

Verified: 213/213 tests pass with db2-sqlglot-dialect==1.1.0
on Python 3.12 and 3.13.

Signed-off-by: IBM Db2 Eco System <Hdm-dev-persona-db2-eco-system@ibm.com>
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 52d6b52f-bc51-4ded-8865-1f925a68b04d
Commits

Reviewing files that changed from the base of the PR and between f6527ff and bf5afd9.

Files selected for processing: 1
  • pyproject.toml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The db2 optional dependency now requires db2-sqlglot-dialect version 1.1.0 or later for Python 3.10 and newer.

Changes: DB2 dependency

Layer / File(s) Summary
Update DB2 dialect version requirement
pyproject.toml
The db2 extra sets the minimum db2-sqlglot-dialect version to 1.1.0. The Python version condition remains unchanged.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested labels: dependencies

Suggested reviewers: cmgoffena13

Merge Risk: Minimal · up to bf5af

The dependency update is narrowly scoped and presents no identified merge-blocking risk.

Architecture risk: Low · up to bf5af

The change affects 1 system.

Changed systems: pyproject.toml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — pyproject.toml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in pyproject.toml: The db2 extra raises the minimum db2-sqlglot-dialect version from unspecified to 1.1.0 for Python 3.10 and newer.
Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the primary change: raising the minimum db2-sqlglot-dialect version to 1.1.0.
Description check Passed The description includes the required Description, Test Plan, and Checklist sections. It explains the dependency change, records targeted test results, and clearly states that the full test suite was …
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the required Description, Test Plan, and Checklist sections. It explains the dependency change, records targeted test results, and clearly states that the full test suite was not run locally.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant