Repository navigation
chore(db2): bump db2-sqlglot-dialect minimum to 1.1.0 - #6170
Open
hdm-db2-eco-system wants to merge 1 commit into
Open
hdm-db2-eco-system wants to merge 1 commit into
hdm-db2-eco-system wants to merge 1 commit into
Conversation
Version 1.1.0 fixes TYPE_MAPPING keys (exp.DType.* -> exp.DataType.Type.*) and adds JSON_KEY_VALUE_PAIR_SEP for correct Db2 JSON_OBJECT syntax. No adapter code changes required. Verified: 213/213 tests pass with db2-sqlglot-dialect==1.1.0 on Python 3.12 and 3.13. Signed-off-by: IBM Db2 Eco System <Hdm-dev-persona-db2-eco-system@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version
1.1.0fixesTYPE_MAPPINGkeys (exp.DType.*→exp.DataType.Type.*) and addsJSON_KEY_VALUE_PAIR_SEP = " VALUE"for correct Db2JSON_OBJECTsyntax. The SQLGlot dependency requirement is now>=30.8.0. No adapter code changes are required.Verified: 213/213 tests pass with
db2-sqlglot-dialect==1.1.0on Python 3.12 and 3.13.Description
Bumps the minimum version of
db2-sqlglot-dialectto>=1.1.0in thedb2extra to ensure compatibility with the updated SQLGlot API and Db2 SQL generation.Test Plan
python -m pytest tests/core/engine_adapter/test_db2.py tests/core/test_dialect.py -x -q.make fast-testwas not run locally because the full development installation is required. CI will run the full suite.Checklist
make styleand fixed any issues (Ruff and Ruff Format passed; MyPy errors are pre-existing and unrelated).make fast-test) — Db2-specific tests passed; full suite will run on CI.git commit -s) per the [DCO](DCO).Summary by CodeRabbit