Repository navigation
Make column type constants constexpr - #609
Merged
Merged
Conversation
Expose the five stable SQLite datatype codes as C++17 inline constants so they can be used in switch labels. Check the values against SQLite headers at build time and cover runtime types.
Document the source and ABI change for SQLiteCpp 4.0 in #609.
|
coverage: 99.735%. remained the same — 302-feature-constexpr-column-types into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the five SQLite column type codes
inline constexprso they work inswitchlabels, without includingsqlite3.hin public headers. Check their values against SQLite at compile time and add a runtime regression test.This intentionally removes the old exported
const intsymbols as part of the 4.0 ABI break. Fixes #302.